Skip to content

chore(ActionList, NavList): Remove the CSS modules feature flag from ActionList and related components #6090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Jun 11, 2025
Merged

chore(ActionList, NavList): Remove the CSS modules feature flag from ActionList and related components #6090

merged 18 commits into from
Jun 11, 2025

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented May 20, 2025 •
edited
Loading

Closes https://github.com/github/primer/issues/5173

Changelog

New

Changed

Removed

Remove the CSS modules feature flag from ActionList and related components

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 20, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 7aebf52

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label May 20, 2025
@github-actions GitHub Actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label May 20, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-6090 May 20, 2025 21:36 Inactive
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 20, 2025 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 91.93 KB (-2.74% 🔽)
packages/react/dist/browser.umd.js 92.03 KB (-2.93% 🔽)

@github-actions github-actions bot temporarily deployed to storybook-preview-6090 May 20, 2025 21:49 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-6090 May 20, 2025 22:03 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-6090 May 20, 2025 22:25 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-6090 May 20, 2025 23:51 Inactive
@github-actions github-actions bot requested a deployment to storybook-preview-6090 May 21, 2025 00:11 Abandoned
@github-actions github-actions bot temporarily deployed to storybook-preview-6090 May 21, 2025 00:25 Inactive
jonrohan
jonrohan commented May 21, 2025
View reviewed changes
packages/react/src/ActionList/shared.ts
@@ -53,6 +53,9 @@ export type ActionListItemProps = {
*/
_PrivateItemWrapper?: React.FC<React.PropsWithChildren<MenuItemProps>>
className?: string
groupId?: string
renderItem?: (item: React.FC<React.PropsWithChildren<MenuItemProps>>) => React.ReactNode
handleAddItem?: (item: React.FC<React.PropsWithChildren<MenuItemProps>>) => void
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wanted to highlight this as something I'm unsure of? @joshblack I had to add these here because of the props I added on the item to satisfy the type errors

@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels May 21, 2025
@primer-integration
Copy link

🟢 golden-jobs completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Jun 4, 2025
@hussam-i-am hussam-i-am marked this pull request as ready for review June 4, 2025 14:28
@hussam-i-am hussam-i-am requested a review from a team as a code owner June 4, 2025 14:28
@hussam-i-am hussam-i-am requested a review from hectahertz June 4, 2025 14:28
@hussam-i-am
Copy link
Contributor

Integration tests are now green, but the realease will need the changes in https://github.com/github/github/pull/381456 for them to pass.

@langermank langermank mentioned this pull request Jun 6, 2025
Merged
13 tasks
@jonrohan jonrohan added this pull request to the merge queue Jun 11, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 11, 2025
@jonrohan jonrohan added this pull request to the merge queue Jun 11, 2025
@jonrohan jonrohan removed this pull request from the merge queue due to a manual request Jun 11, 2025
@github-actions GitHub Actions
Copy link
Contributor

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jun 11, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-6090 June 11, 2025 18:30 Inactive
@github-actions github-actions bot added integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Jun 11, 2025
@github-actions GitHub Actions
Copy link
Contributor

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@jonrohan jonrohan enabled auto-merge June 11, 2025 18:36
@jonrohan jonrohan added this pull request to the merge queue Jun 11, 2025
Merged via the queue into main with commit 7bbdcab Jun 11, 2025
35 checks passed
@jonrohan jonrohan deleted the css_modules_remove_flag/actionlist branch June 11, 2025 19:00
@primer primer bot mentioned this pull request Jun 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hussam-i-am hussam-i-am hussam-i-am approved these changes

@hectahertz hectahertz Awaiting requested review from hectahertz hectahertz is a code owner automatically assigned from primer/engineer-reviewers

Assignees

@jonrohan jonrohan

@hussam-i-am hussam-i-am

Labels
integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonrohan @hussam-i-am @francinelucca