-
Notifications
You must be signed in to change notification settings - Fork 621
chore(ActionMenu): Add fullscreen capabilities #6108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
fe6ed7d
chore(ActionMenu): Add fullscreen sample story
francinelucca 2596f3c
Create pink-trees-work.md
francinelucca 51b85aa
Merge branch 'main' of github.com:primer/react into chore/add-action-…
francinelucca 0877e5c
refactor: bubble up close button to AnchoredOverlay
francinelucca 5e5eb27
Merge branch 'main' into chore/add-action-menu-full-screen-story
francinelucca 83280ee
format
francinelucca 5513948
lint fixes
francinelucca 8e958b6
test(vrt): update snapshots
francinelucca 056ca3b
Revert "test(vrt): update snapshots"
francinelucca a4f6994
Merge branch 'main' into chore/add-action-menu-full-screen-story
francinelucca 205b625
Merge branch 'main' into chore/add-action-menu-full-screen-story
francinelucca 40fb418
test(vrt): update snapshots
francinelucca dbf78fc
Merge branch 'main' into chore/add-action-menu-full-screen-story
francinelucca ae40b39
Update packages/react/src/AnchoredOverlay/AnchoredOverlay.tsx
francinelucca 2831be5
Update packages/react/src/ActionMenu/ActionMenu.module.css
francinelucca 4853135
Merge branch 'main' into chore/add-action-menu-full-screen-story
francinelucca 658a986
Merge branch 'main' of github.com:primer/react into chore/add-action-…
francinelucca fc2bc41
add displayCloseButton, closeButtonProps to AnchoredOverlay, fix visu…
francinelucca c367bc7
fix double close button
francinelucca d01faca
format
francinelucca 7c858e1
test(vrt): update snapshots
francinelucca 1cc101a
visual reg fix
francinelucca 6a5b157
Merge branch 'chore/add-action-menu-full-screen-story' of github.com:…
francinelucca d42108e
lint fix
francinelucca 8c24cf1
test(vrt): update snapshots
francinelucca b0c0f1a
Merge branch 'main' into chore/add-action-menu-full-screen-story
francinelucca 92cb54c
add min-height to fullscreen mode
francinelucca 078fc96
Merge branch 'main' into chore/add-action-menu-full-screen-story
francinelucca b389e1b
test(vrt): update snapshots
francinelucca 95ef218
Revert "test(vrt): update snapshots"
francinelucca 182ea67
Revert "test(vrt): update snapshots"
francinelucca 53e37b8
Revert "test(vrt): update snapshots"
francinelucca 2746d78
Revert "test(vrt): update snapshots"
francinelucca File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@primer/react": patch | ||
--- | ||
|
||
chore(ActionMenu): Add fullscreen sample story and variant prop |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.