-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Closed
Labels
Area: Code QualityFor refactoring, cleanup, or improvements to maintainabilityFor refactoring, cleanup, or improvements to maintainabilityBugError or unexpected behaviorsError or unexpected behaviorsPriority:MediumModerately important, should be completed in a fair timeframeModerately important, should be completed in a fair timeframe
Milestone
Description
p5.js version
No response
What is your operating system?
None
Web browser and version
No response
Actual Behavior
Adding a sketch to a collection works just fine, this is only a code-quality issue.
I'm seeing two prop-types validation errors on the CollectionList
modal:
checkPropTypes.js:20 Warning: Failed prop type: The prop
projectId
is marked as required inCollectionList
, but its value isnull
.
in CollectionList (created by Connect(CollectionList))
checkPropTypes.js:20 Warning: Failed prop type: The prop
collections[0].items[0].project.createdAt
is marked as required inCollectionList
, but its value isundefined
.
in CollectionList (created by Connect(CollectionList))
Expected Behavior
It should not have errors.
Steps to reproduce
Steps:
- Open a sketch
- Click "File" menu
- Click "Add to Collection"
Metadata
Metadata
Assignees
Labels
Area: Code QualityFor refactoring, cleanup, or improvements to maintainabilityFor refactoring, cleanup, or improvements to maintainabilityBugError or unexpected behaviorsError or unexpected behaviorsPriority:MediumModerately important, should be completed in a fair timeframeModerately important, should be completed in a fair timeframe