Skip to content

Fix errors sending emails (#2303) #2306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 216 commits into from
Aug 16, 2023
Merged

Conversation

lindapaiste
Copy link
Collaborator

Fixes #2303
(Probably, but I haven't checked it with a valid Mailgun config to make sure that it works all the way through to sending the email.)

We merged a dependabot PR #2267 which included a major version bump of mjml and that caused emails to break.

Changes:

  • Import mjml2html as the default from mjml instead of a named import.
  • Remove deprecated component <mj-container> from templates.
  • Convert unitless value width="192" to px width="192px".
  • Log errors when calling mjml2html (useful in development, probably does nothing in production but idk).

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

dewanshDT and others added 30 commits March 3, 2023 07:25
Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this fix! I was able to test it locally with a Mailgun key and I received an email.

@raclim raclim changed the base branch from develop to release August 16, 2023 18:09
@raclim raclim merged commit 7ef3f7e into processing:release Aug 16, 2023
raclim added a commit that referenced this pull request Aug 16, 2023
@raclim raclim mentioned this pull request Aug 16, 2023
4 tasks
raclim added a commit that referenced this pull request Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Error or unexpected behaviors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error sending confirmation email
7 participants