Skip to content

added liveloading to the search bar result count #2617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mhsh312
Copy link
Contributor

@mhsh312 mhsh312 commented Nov 17, 2023

Fixes #2614

Changes:

  • Added the functionality of live loading as mentioned in Live Loading of 'Find' Results #2614 by adding the ability to update the UI in the startSearch function
  • handled the edge case of changing the entire input field at once by selecting the test using cursor.findNext() 
  • handled code highlighting and de-highlighting in live loading as well
searchFix.mp4

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

Copy link
Collaborator

@lindapaiste lindapaiste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you! 🥇

@lindapaiste lindapaiste merged commit 42924b9 into processing:develop Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Live Loading of 'Find' Results
3 participants