Update otel target to handle breaking change #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerHelmuth
force-pushed
the
update-otel-target
branch
from
e5aeb35 to
d30df9a
Compare
sfc-gh-bdrutu
approved these changes
Apr 1, 2025
bogdandrutu
approved these changes
Apr 1, 2025
bogdandrutu
reviewed
Apr 2, 2025
Signed-off-by: Tyler Helmuth <[email protected]>
Signed-off-by: Tyler Helmuth <[email protected]>
TylerHelmuth
force-pushed
the
update-otel-target
branch
from
4df8f11 to
d3f44c8
Compare
This was referenced Apr 14, 2025
Merged
TylerHelmuth
added a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Apr 14, 2025
#### Description prometheus/compliance#160 is merged, updating workflow to use new binary name #### Link to tracking issue Fixes #39105
akshays-19
pushed a commit
to akshays-19/opentelemetry-collector-contrib
that referenced
this pull request
Apr 23, 2025
#### Description prometheus/compliance#160 is merged, updating workflow to use new binary name #### Link to tracking issue Fixes open-telemetry#39105
Fiery-Fenix
pushed a commit
to Fiery-Fenix/opentelemetry-collector-contrib
that referenced
this pull request
Apr 24, 2025
#### Description prometheus/compliance#160 is merged, updating workflow to use new binary name #### Link to tracking issue Fixes open-telemetry#39105
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The v0.123.0 release of collector core has promoted a feature gate to beta that removes support for
service.telemetry.metrics.address. As of v0.123.0 this setting does nothing unless the feature gate is disabled.Since the collector is moving away from
service.telemetry.metrics.addressin favor of the otel sdk configuration, this PR updates the otel target to use the otel go's metrics SDK to export metrics via prometheus.Collector contrib has a workflow that is failing right now because of the breaking change, but this PR will fix it.
Closes open-telemetry/opentelemetry-collector-contrib#39105