Added conditional for WebDriver in 'screenshotElement' method. #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! This works!! |
|
Thanks for testing and thanks for the patch @tairun 👍 will be available in the next release |
|
@tairun can you please send PR to the upstream project? |
puneet0191
approved these changes
Jul 30, 2019
Sorry for the delay. PR in upstream is available now. Sidenote 1: Why did you fork the project if you are the one managing the original one? |
puneet0191
added a commit
that referenced
this pull request
Aug 21, 2019
Added conditional for WebDriver in 'screenshotElement' method. (#2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Poor man's patch to make 'screenshotElement' method work with WebDriver helper.