Skip to content

(maint) fix update node pp #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

seamymckenna
Copy link
Contributor

Summary

Fix for the below issue

puppetlabs/comply-demo % bundle exec bolt -i ./spec/fixtures/litmus_inventory.yaml --native-ssh task run provision::update_node_pp --targets bodily-pitcher.delivery.puppetlabs.net target_node=bodily-pitcher.delivery.puppetlabs.net manifest=test

Started on bodily-pitcher.delivery.puppetlabs.net...
Failed on bodily-pitcher.delivery.puppetlabs.net:
  The task failed with exit code 1 and no stdout, but stderr contained:
  /tmp/2db07819-a48a-475a-9ec6-9efaa81f79f8/update_node_pp.rb:12: syntax error, unexpected '}'
  ...r: ' %{stderr}')" % { stderr: }) if status != 0
  ...                              ^
Failed on 1 target: bodily-pitcher.delivery.puppetlabs.net
Ran on 1 target in 15.09 sec

line getting exercised as status now returns value like "pid 27325 exit 0" as its string representation.
We should use success? method instead

@seamymckenna seamymckenna requested a review from a team as a code owner July 1, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant