(PUP-10896) Fix gid idempotency on user resource #8511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a regression of puppetlabs#8501 which made `forcelocal` act different when setting the `gid` parameter. Since we were returning the GID of an user as a string, Puppet made the assumption that the GID wasn't a number. This caused issues when setting gid to a string value (like `gid => 'abc'`), which is allowed in Puppet. To fix this, ensure we return the GID as integer after searching `/etc/passwd`. If for some reason it cannot be converted, it is returned as is (highly unlikely as non-numeric GIDs are not allowed in `/etc/passwd`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a regression of #8501 which made
forcelocalact different whensetting the
gidparameter.Since we were returning the GID of an user as a string, Puppet made the
assumption that the GID wasn't a number. This caused issues when setting
gid to a string value (like
gid => 'abc'), which is allowed in Puppet.To fix this, ensure we return the GID as integer after searching
/etc/passwd. If for some reason it cannot be converted, it is returnedas is (highly unlikely as non-numeric GIDs are not allowed in
/etc/passwd).