Skip to content

(PUP-10896) Fix user gid property when forcelocal is true #8512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

(PUP-10896) Fix user gid property when forcelocal is true #8512

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/puppet/provider/user/useradd.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ def local_username

def localuid
user = finduser(:account, resource[:name])
return user[:uid] if user
return user[:uid].to_i if user
false
end

Expand Down
4 changes: 2 additions & 2 deletions spec/unit/provider/user/useradd_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,14 +360,14 @@
resource[:forcelocal] = true
allow(Puppet::FileSystem).to receive(:exist?).with('/etc/passwd').and_return(true)
allow(Puppet::FileSystem).to receive(:each_line).with('/etc/passwd').and_yield(content)
expect(provider.gid).to eq('999')
expect(provider.gid).to eq(999)
end

it "should fall back to nameservice GID when forcelocal is false" do
resource[:forcelocal] = false
allow(provider).to receive(:get).with(:gid).and_return('1234')
expect(provider).not_to receive(:localgid)
expect(provider.gid).to eq('1234')
expect(provider.gid).to eq(1234)
end
end

Expand Down