(maint) Merge 7.9.0_release into main #8735
Merged
+0
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bug arose from adding the option to use debug logging to the puppetserver-ca gem. The error happened when the test for Puppet's 'clean' face in 6.x is ran. The reason behind the error is because we did not have a 'debug' option in our 'LoggerIO' class in 'clean' face. Thus, the solution to the bug is to include the 'debug' option in our logger by adding a debug function in the LoggerIO class. Furthermore, we decided to include the 'warn' option for the logger similar to Puppet's 'clean' face in 7.x so that it's less of a hassle when merging and having a uniform code base.
…lean-log (maint) Fix a bug with the logger in clean.rb
GabrielNagy
approved these changes
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.