Skip to content

(CONT-406) Fix for RHEL 7 compatibility #2362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 21, 2022

Conversation

david22swan
Copy link
Member

A previous PR had updated the security_crs.comf.erb file to a more modern version, however this has rendered it incompatible with RHEL 7. This PR introduces and if to solve the issue.

Also includes a quick fix to remove legacy facts from a template file.

@david22swan david22swan requested a review from a team as a code owner December 20, 2022 15:01
Copy link
Collaborator

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't mind converting to EPP eventually, but we're not there today.

A previous PR had updated the security_crs.comf.erb file to a more modern version, however this has rendered it incompatible with RHEL 7.
This PR introduces and if to solve the issue.

Also includes a quick fix to remove legacy facts from a template file.
@david22swan david22swan force-pushed the CONT-406/rstore_redhat_7_comp branch from 535f674 to 175d6d4 Compare December 21, 2022 10:11
Copy link
Contributor

@GSPatton GSPatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@GSPatton GSPatton merged commit e7a5767 into puppetlabs:main Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants