Skip to content

0.12 Updates #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 4, 2018
Merged

0.12 Updates #147

merged 8 commits into from
May 4, 2018

Conversation

natefaubion
Copy link
Collaborator

Should I move the namespace to Effect.Aff?

@natefaubion natefaubion requested review from garyb and kritzcreek May 1, 2018 04:39
@garyb
Copy link
Member

garyb commented May 2, 2018

What's happening with the Aff version of AVar if we're dropping it from here?

@garyb
Copy link
Member

garyb commented May 2, 2018

Regarding namespace, Effect.Async might work too?

@natefaubion
Copy link
Collaborator Author

I just thought it would be weird to export Aff from Effect.Async. I can also just export it under Aff, without a prefix.

@natefaubion
Copy link
Collaborator Author

I'm going to move Aff bindings to purescript-avar.

garyb
garyb approved these changes May 3, 2018
View reviewed changes
Copy link
Member

@garyb garyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aff or Effect.Aff or Effect.Async are all fine by me. I'll let you decide and take the blame 😛

kritzcreek
kritzcreek approved these changes May 3, 2018
View reviewed changes
Copy link
Contributor

@kritzcreek kritzcreek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ❤️ Gary's approach, so I'll let you decide on the naming :D

@natefaubion natefaubion merged commit eaf3d06 into purescript-contrib:compiler/0.12 May 4, 2018
@natefaubion natefaubion deleted the eff-off branch May 4, 2018 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garyb garyb garyb approved these changes

@kritzcreek kritzcreek kritzcreek approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@natefaubion @garyb @kritzcreek