Change type of log and print to return Unit #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It might be easier to see what was changed by looking at the commits individually: |
|
Since the type of Also, the docs should be regenerated. I didn't include the updated docs in this commit. |
|
👍 Can you squash all the commits? |
`log` from `Control.Monad.Aff.Console` is a wrapper around `log` from
`Control.Monad.Eff.Console`.
The type of `log` from `Control.Monad.Eff.Console` is as follows:
log :: forall eff. String -> Eff (console :: CONSOLE | eff) Unit
However, `log` from `Control.Monad.Aff.Console` is as follows:
log :: forall eff. String -> Aff (console :: CONSOLE | eff) String
This pull request makes `log` return `Unit` instead of `String`. This
closes issue purescript-contrib#41.
This also changes the type of `Control.Monad.Aff.Console.print` to
return `Unit`, and cleans up warnings and weird indentation in the
`examples/src/Examples.purs` file.
cdepillabout
force-pushed
the
change-type-of-log
branch
from
a7f04cd to
ae9c72f
Compare
|
All code has been squashed in commit ae9c72f. |
jdegoes
added a commit
that referenced
this pull request
Jan 12, 2016
Change type of log and print to return Unit
|
@cdepillabout Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the type of
logandprintto returnUnitinstead ofStringandarespectively.This closes issue #41.
This pull request also contains two commits to clean up the compiler warnings and indentation in the Examples.purs file.