Skip to content

Rearrange FFI into IIFE for bundling #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 20, 2017
Merged

Rearrange FFI into IIFE for bundling #6

merged 2 commits into from
Sep 20, 2017

Conversation

natefaubion
Copy link
Contributor

No description provided.

@natefaubion natefaubion requested a review from garyb September 20, 2017 14:28
@natefaubion natefaubion mentioned this pull request Sep 20, 2017
Closed
garyb
garyb approved these changes Sep 20, 2017
View reviewed changes
Copy link
Member

@garyb garyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 just a linter complaint failing the build now.

@natefaubion natefaubion merged commit bf4fe9c into purescript-contrib:master Sep 20, 2017
zyla added a commit to restaumatic/purescript-arrays that referenced this pull request Nov 29, 2018
@zyla
Wrap FFI in IIFE to avoid breaking bundling
9dbd74f 
See also: purescript#145

See also: purescript-contrib/purescript-avar#6
@rhendric rhendric mentioned this pull request Dec 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garyb garyb garyb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@natefaubion @garyb