-
Notifications
You must be signed in to change notification settings - Fork 79
Adds license parsing to main pipeline #257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -12,6 +12,7 @@ import Foreign.SemVer (SemVer, parseSemVer) | |||
import Registry.PackageName (PackageName) | |||
import Registry.PackageName as PackageName | |||
import Registry.Schema (Repo(..)) | |||
import Registry.License as RLicense |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import Registry.License as RLicense | |
import Registry.License as License |
@@ -397,7 +368,7 @@ constructManifestFields package version address = do | |||
-- We can detect the license for the project using a combination of `licensee` | |||
-- and reading the license directly out of the Spago and Bower files (the | |||
-- CLI tool will not read from either file). | |||
licenseeOutput <- detectLicense files | |||
licenseeOutput <- detectLicense files ------------------ pull this out |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When pulling this out, keep in mid that we still need to do the work below -- where we pull the licenses out of the Spago manifest and Bowerfile -- because we detect the licenses using a combination of licensee
(which checks the LICENSE file and package.json file) and the licenses we pull out of the other manifest files. So the entire thing will need to be factored out.
@thomashoneyman when you get a chance, could you take a peek here and let me know if I'm going in the right direction? Basically, I created If you sign off on this leg of work, the next step will be using |
I'll close this in favor of #288 |
No description provided.