-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Closed
Description
Describe the bug
After #823 is merged there may be stale comments in pvlib.tracking.singleaxis
and commented code that can be removed. This might make the code more readable. It would also resolve some stickler complaints about long lines.
To Reproduce
Comments to remove:
- L375-L379 - the tracking algorithm now follows [1] that uses clockwise rotation around z-axis from north
- L393-L395 - ditto
- L400-L410 - ditto
- L441-L452 - pvlib has been using arctan2(x,z) in
pvlib.tracking.singleaxis
for 6 years since 1fb82cc, so I believe these comments are unnecessary now - L471-L472 - this commented code was updated in Singleaxis tracking with non-parallel slope #823, should we leave it or delete it?
- L553-L555
etc.
[1] https://www.nrel.gov/docs/fy20osti/76626.pdf
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Versions:
pvlib.__version__
:pandas.__version__
:- python:
Additional context
Add any other context about the problem here.
Metadata
Metadata
Assignees
Labels
No labels