-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Closed
Labels
Milestone
Description
pvlib.soiling.hsu
takes a tilt
parameter representing the same thing we normally call surface_tilt
:
Lines 13 to 14 in 7a2ec9b
def hsu(rainfall, cleaning_threshold, tilt, pm2_5, pm10, | |
depo_veloc=None, rain_accum_period=pd.Timedelta('1h')): |
Lines 33 to 34 in 7a2ec9b
tilt : float | |
Tilt of the PV panels from horizontal. [degree] |
I don't see any good reason for this naming inconsistency (I suspect tilt
just got copied from the matlab implementation) and suggest we rename the parameter to surface_tilt
with a deprecation.
Also, the docstring parameter type description says it must be float
, but the model's reference explicitly says time series tilt is allowed:
The angle is variable for tracking systems and is taken as the average angle over the time step.
wholmgren