-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add 2025 coefficients for Huld model #2486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
OmarBahamida
wants to merge
16
commits into
pvlib:main
Choose a base branch
from
OmarBahamida:fix2461
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
4b66810
Enhance Huld model with EU JRC coefficients
OmarBahamida 928207e
Refactor Huld model tests for EU JRC coefficients
OmarBahamida 1833dc1
Fix Flake8 linter errors
OmarBahamida 98846e6
Fix Flake8 errors:
OmarBahamida 241c272
restructure lookup and test
cwhanse 79f490f
fix test and formatting
cwhanse a5a5ae8
adjust error message
cwhanse aa7d3ee
Merge branch 'main' of https://github.com/pvlib/pvlib-python into fix…
cwhanse 91da25c
add whatsnew
cwhanse 140b55b
Apply suggestions from code review
cwhanse 752ef05
Update pvlib/pvarray.py
cwhanse 0703ac1
Update pvlib/pvarray.py
cwhanse 889805b
Update pvlib/pvarray.py
cwhanse 57edf70
correct coefficients for 2025 and references
cwhanse 92b5cde
fix conflict
cwhanse 8b41911
fix docstring
cwhanse File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think
'2011'
is a good choice of identifier for the older coefficients. To me it suggests the 2011 paper is the source of those coefficients, which isn't the case.I think something like
PVGIS5.3
(the current version) andPVGIS{something}
could be a good option, but I don't know what version will have the new coefficients. I've emailed Nikos Alexandris at JRC asking about this.