Add NASA POWER to iotools

[IoannisSifnaios]

• I am familiar with the contributing guidelines
• Tests added
• Updates entries in docs/sphinx/source/reference for API changes.
• Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
• New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
• Pull request is nearly complete and ready for detailed review.
• Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

This PR adds a function to get irradiance and weather data from NASA POWER. read_the_docs_link

[IoannisSifnaios]

@AdamRJensen could you give some first feedback on this?

Also, should there also be a read_nasa_power function or not?

[AdamRJensen]

Also, should there also be a read_nasa_power function or not?

I suggest just adding a get_nasa_power function for now. If there is a need for a read function, we can always add that later.

[AdamRJensen]

Initial review

[kandersolar]

A few comments, overall looks pretty good to me! Seems like the API is a little slow but not terrible: 16 seconds for a year of data.

[IoannisSifnaios]

When running pytest locally, it says that the first test is skipped. Any ideas why this is (and also, is it a problem)?

[echedey-ls]

When running pytest locally, it says that the first test is skipped. Any ideas why this is (and also, is it a problem)?

@IoannisSifnaios that's due to the flags that make the iotools tests only run when explicitly requested. The pytest command you must run is in workflows/pytest-remote-data.yml:

run: pytest tests/iotools --cov=./ --cov-report=xml --remote-data

cov parameters are just for the coverage file, you don't need em.

[IoannisSifnaios]

When running pytest locally, it says that the first test is skipped. Any ideas why this is (and also, is it a problem)?

@IoannisSifnaios that's due to the flags that make the iotools tests only run when explicitly requested. The pytest command you must run is in workflows/pytest-remote-data.yml:

run: pytest tests/iotools --cov=./ --cov-report=xml --remote-data

cov parameters are just for the coverage file, you don't need em.

I guess based on the workflow description, there should also be a remote_data label added, right?

[echedey-ls]

there should also be a remote_data label added, right?

Yup, that's right!

Edit: in fact, see it's one of the instructions (the last one) on the PR template