Skip to content

Test smart_holder in virtual inheritance #5796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

MannixYang
Copy link

@MannixYang MannixYang commented Aug 15, 2025

Description

This is a Test PR.
Related issues #5786 .
The error occurred at Visual Studio 17 2022 X64.

Suggested changelog entry:

  • Placeholder.

@rwgk
Copy link
Collaborator

rwgk commented Aug 15, 2025

After you push the clang-tidy fix (remove the redundant virtual), could you please mark this PR as "Ready for review"? That's the trick to get the full CI matrix.

@MannixYang MannixYang marked this pull request as ready for review August 15, 2025 05:10
@MannixYang MannixYang requested a review from henryiii as a code owner August 15, 2025 05:10
@rwgk
Copy link
Collaborator

rwgk commented Aug 15, 2025

From

https://chatgpt.com/share/689ee2ee-514c-8008-9d6b-2566dec08a6e

"the reproducer only triggers under MSVC x64"

@MannixYang Did you already try to get a backtrace? That'll probably help enormously in homing in on the root cause. (ChatGPT has a few guesses.)

@MannixYang
Copy link
Author

@rwgk Sorry for replying to you so late.
I can't even catch the exception using try-except. Is there any other better way to get the backtrace in pybind11-test.

def test_animals():
    tiger = m.Tiger()
    try:
        tiger.clone()
    except Exception as e:
        pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants