Draft Idea For Pre Tasks To Be Context Aware #1041
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aantillonl
force-pushed
the
dev
branch
2 times, most recently
from
9570e22 to
2b2da60
Compare
This commit introduces, in a draft state, the idea to allow tasks that are called as a pre task for another task, to keep state of this pre task assignment via the attribute `_is_pre_of`. This attribute is later used when a `Call` object is created from a `Task` instance that has said attribute set. A `Call` created from a pre task, will add a reference to the task that defines the current task as pre task, and said reference will be available during the pre task's execution in the context passed to the task. The approach here suggested uses Pythonic patterns to avoid changes to the class implementation as much as possible, but rather compose the new functionality from invidivual, signle purpose small components, such as a generic decorator, and a descriptor component. It can be very well the case that making a task more stateful by tracking this pre assignment is not aligned with the design if this library, in which case it would be better not to add functionality that is not part of the long term view for the library. I would be happy to contribute to this greaat library in other ways.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a draft implementation of a mechanism that allows tasks designated as pre-tasks to retain information about their assignment via a
_is_pre_ofattribute.When a
Callobject is created from aTaskinstance with this attribute set, the resultingCallwill include a reference to the main task that declared the current task as a pre-task. This reference is made accessible during the pre-task's execution through the context passed to the task, allowing for greater introspection or conditional behavior based on the calling task.The approach taken here favors composability and minimal intrusion into existing class implementations. It uses idiomatic Python patterns—such as generic decorators and lightweight descriptors—to introduce this functionality without tightly coupling it to the core
TaskorCallclasses.It’s possible that making tasks more stateful in this way—by tracking their assignment as pre-tasks—may not align with the long-term design philosophy of this library. If that's the case, I completely understand, and I'm happy to explore other areas where I could contribute to this great project.
There are a few issues in the CI pipeline, if this idea gets some push, I will address them promptly
ToDo