Support Direct URL editable requirements #13495
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ichard26
force-pushed
the
feat/direct-editables
branch
from
4164131 to
47e7040
Compare
ichard26
commented
Jul 20, 2025
| @@ -66,8 +66,8 @@ for the name and project version (this is in theory slightly less reliable | |||
| than using the ``egg_info`` command, but avoids downloading and processing | |||
| unnecessary numbers of files). | |||
|
|
|||
| Any URL may use the ``#egg=name`` syntax (see :doc:`../topics/vcs-support`) to | |||
| explicitly state the project name. | |||
| The :pep:`508` requirement syntax can be used to explicitly state the project | |||
There was a problem hiding this comment.
I hate that I'm adding more references to individual PEPs in the user documentation, but I legitimately don't know where to find a good user guide for Direct URL requirements. Linking to the specification is not exactly user friendly. I defaulted to linking the PEP as this document already does that.
Suggestions would be welcome.
There was a problem hiding this comment.
Add a reference to https://packaging.python.org/en/latest/specifications/dependency-specifiers/#dependency-specifiers instead of the PEP.
ichard26
force-pushed
the
feat/direct-editables
branch
from
47e7040 to
fcae387
Compare
|
Ugh, why is everything filled with so many exceptions and undocumented extensions. There is a backwards compatibility break here. I'll fix it, but I do want to take a closer look at why it's happening. |
This is crucial for the deprecation of non-bare egg URL fragments as they used to be the sole way to request an extra for a VCS editable install. I've also removed all references to egg fragments from the user docs and added further explanation of the Direct URL form in the VCS support topic. Getting the error handling right was a pain. That's why I extracted the two parsing flows into their own functions. Co-authored-by: Tzu-ping Chung <[email protected]>
ichard26
force-pushed
the
feat/direct-editables
branch
from
fcae387 to
8850376
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is crucial for the deprecation of non-bare egg URL fragments as they used to be the sole way to request an extra for a VCS editable install.
I've also removed all references to egg fragments from the user docs and added further explanation of the Direct URL form in the VCS support topic.
Getting the error handling right was a pain. That's why I extracted the two parsing flows into their own functions.
Towards #13157.
Towards #1289.
Supersedes #9471.