Skip to content

No user generated UUID #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 5, 2022
Merged

No user generated UUID #33

merged 4 commits into from
Sep 5, 2022

Conversation

ntoll
Copy link
Member

@ntoll ntoll commented Sep 5, 2022

This small PR makes two minor adjustments:

  • No user generated UUID is added to the manifest.toml file upon app creation.
  • Revised unit tests to reflect this change.

The UUID is now generated by the API and this should be the single canonical source of such ids.

mattkram
mattkram approved these changes Sep 5, 2022
View reviewed changes
Copy link
Collaborator

@mattkram mattkram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Answers an outstanding question I forgot to ask last PR 🙂

@ntoll ntoll merged commit a8eb410 into main Sep 5, 2022
@ntoll ntoll deleted the no-user-generated-id branch September 5, 2022 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattkram mattkram mattkram approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ntoll @mattkram