Skip to content

Update matrix_to_dicts and fix generalized_degree #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2022

Conversation

eriknw
Copy link
Member

@eriknw eriknw commented Oct 29, 2022

Now matrix_to_dicts can return either the node id or row or column index.

Of course we'd like more tests and coverage with this... but we'd like that lots of places! ;)

Now `matrix_to_dicts` can return either the node id or row or column index.
@eriknw eriknw requested a review from jim22k October 29, 2022 17:05
@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2022

Codecov Report

Base: 73.20% // Head: 72.99% // Decreases project coverage by -0.20% ⚠️

Coverage data is based on head (d896e4a) compared to base (58cdf50).
Patch coverage: 36.36% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
- Coverage   73.20%   72.99%   -0.21%     
==========================================
  Files          67       67              
  Lines        2314     2322       +8     
  Branches      430      436       +6     
==========================================
+ Hits         1694     1695       +1     
- Misses        462      466       +4     
- Partials      158      161       +3     
Impacted Files Coverage Δ
graphblas_algorithms/classes/_utils.py 72.41% <30.00%> (-3.50%) ⬇️
graphblas_algorithms/nxapi/cluster.py 77.55% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jim22k jim22k merged commit 65fb70c into python-graphblas:main Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants