Skip to content

Add Django 2.2 wrapper #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

plambein
Copy link

I simply added a wrapper for Django 2.2 requests and responses. Not sure if and where I should add integration tests, feedback is welcome.

@codecov
Copy link

codecov bot commented Oct 10, 2019

Codecov Report

Merging #162 into master will decrease coverage by 2.03%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #162      +/-   ##
==========================================
- Coverage   95.94%   93.91%   -2.04%     
==========================================
  Files          62       63       +1     
  Lines        1702     1742      +40     
==========================================
+ Hits         1633     1636       +3     
- Misses         69      106      +37
Impacted Files Coverage Δ
openapi_core/wrappers/django.py 0% <0%> (ø)
openapi_core/schema/schemas/_format.py 90.9% <0%> (+3.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df5fbe7...91c346b. Read the comment docs.

@p1c2u
Copy link
Collaborator

p1c2u commented Oct 15, 2019

@plambein Thank you for the contribution. This is great. I will take a closer look and figure out how to cover it with tests.

@p1c2u
Copy link
Collaborator

p1c2u commented Oct 20, 2019

I rebased and reworked the branch with new factories #167 .Closing this one.

@p1c2u p1c2u closed this Oct 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants