Skip to content

[mps] Add offsets to enable aoti #2484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 8, 2025
Merged

[mps] Add offsets to enable aoti #2484

merged 6 commits into from
Jul 8, 2025

Conversation

angelayi
Copy link
Contributor

@angelayi angelayi commented Jul 3, 2025

Stack from ghstack (oldest at bottom):

In AOTI we allocate all weights in one blob and index into the blob based on the offsets. This caused an accuracy error when running the lowbit kernels since it assumes all the offsets are 0.

angelayi added 2 commits July 3, 2025 09:22
[ghstack-poisoned]
[ghstack-poisoned]
Copy link

pytorch-bot bot commented Jul 3, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2484

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit dfe2c98 with merge base 61d49d4 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 3, 2025
@angelayi angelayi requested review from manuelcandales and malfet July 3, 2025 16:23
@angelayi angelayi added the topic: not user facing Use this tag if you don't want this PR to show up in release notes label Jul 3, 2025
[ghstack-poisoned]
angelayi added a commit that referenced this pull request Jul 3, 2025
ghstack-source-id: 96141f8
Pull-Request-resolved: #2484
[ghstack-poisoned]
angelayi added a commit that referenced this pull request Jul 3, 2025
ghstack-source-id: 1fdd0e4
Pull-Request-resolved: #2484
angelayi added 2 commits July 7, 2025 13:36
[ghstack-poisoned]
[ghstack-poisoned]
@angelayi angelayi mentioned this pull request Jul 7, 2025
@angelayi angelayi changed the base branch from gh/angelayi/1/base to main July 8, 2025 00:10
@angelayi angelayi merged commit e9644da into main Jul 8, 2025
33 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing Use this tag if you don't want this PR to show up in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants