Call target_link_options_shared_lib in executorch-config.cmake #12320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Stack from ghstack (oldest at bottom): |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12320
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 Cancelled Job, 3 Unrelated FailuresAs of commit de72b49 with merge base bf4acb3 ( CANCELLED JOB - The following job was cancelled. Please retry:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
swolchok
added a commit
that referenced
this pull request
Jul 9, 2025
Customers need the flags this sets, otherwise the built operator libraries won't actually register operators. Testing: I'm not sure that we have automated coverage for this file, so I'm sending a first version adding an intentional break. ghstack-source-id: d3a9d52 ghstack-comment-id: 3054284839 Pull-Request: #12320
facebook-github-bot
added
the
CLA Signed
[ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Jul 9, 2025
Customers need the flags this sets, otherwise the built operator libraries won't actually register operators. Testing: I'm not sure that we have automated coverage for this file, so I'm sending a first version adding an intentional break. ghstack-source-id: fc72c1b ghstack-comment-id: 3054284839 Pull-Request: #12320
[ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Jul 9, 2025
Customers need the flags this sets, otherwise the built operator libraries won't actually register operators. Testing: I'm not sure that we have automated coverage for this file, so I'm sending a first version adding an intentional break. ghstack-source-id: 1ce1a47 ghstack-comment-id: 3054284839 Pull-Request: #12320
swolchok
added
the
release notes: build
|
size regression seems to be several KB, need to investigate |
[ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Jul 10, 2025
Customers need the flags this sets, otherwise the built operator libraries won't actually register operators. Testing: I'm not sure that we have automated coverage for this file, so I'm sending a first version adding an intentional break. ghstack-source-id: 31c2b55 ghstack-comment-id: 3054284839 Pull-Request: #12320
|
binary size tests are passing. looks like a lot of jobs were cancelled and we just need to retry |
larryliu0820
approved these changes
Jul 10, 2025
|
This error is what called redundant: https://github.com/pytorch/executorch/actions/runs/16207706949/job/45761626062 |
larryliu0820
added a commit
to pytorch/ao
that referenced
this pull request
Jul 11, 2025
After pytorch/executorch#12320 we started to add `--whole-archive` to libraries in `executorch-config.cmake`. This means when we `find_packages(executoch)` and link `${EXECUTORCH_LIBRARIES}`, we started to actually link portable libs: `portable_ops_lib`. This behavior change is breaking because outside of experimental when we build the `llama_runner` library we are linking `optimized_native_cpu_ops_lib` (which contains exactly the same ops but different kernels) as well: https://github.com/pytorch/executorch/blob/main/examples/models/llama/CMakeLists.txt#L95-L101 This results in runtime error: ``` + ./cmake-out/examples/models/llama/llama_main --model_path=model.pte --tokenizer_path=tokenizer.bin '--prompt=Once upon a time,' I tokenizers:regex.cpp:27] Registering override fallback regex E 00:00:00.000453 executorch:operator_registry.cpp:89] Re-registering aten::_cdist_forward.out, from NOT_SUPPORTED I 00:00:00.000494 executorch:operator_registry.cpp:90] key: (null), is_fallback: true F 00:00:00.000497 executorch:operator_registry.cpp:114] In function register_kernels(), assert failed (false): Kernel registration failed with error 18, see error log for details. ``` Like in this job: https://github.com/pytorch/executorch/actions/runs/16207706949/job/45761626062 In order to fix this, we change the logic of linking `${EXECUTORCH_LIBRARIES}` which includes both core and kernel ops lib into only linking `executorch_core`, because the kernel ops lib will be linked outside anyways.
larryliu0820
added a commit
to pytorch/ao
that referenced
this pull request
Jul 11, 2025
After pytorch/executorch#12320 we started to add `--whole-archive` to libraries in `executorch-config.cmake`. This means when we `find_packages(executoch)` and link `${EXECUTORCH_LIBRARIES}`, we started to actually link portable libs: `portable_ops_lib`. This behavior change is breaking because outside of experimental when we build the `llama_runner` library we are linking `optimized_native_cpu_ops_lib` (which contains exactly the same ops but different kernels) as well: https://github.com/pytorch/executorch/blob/main/examples/models/llama/CMakeLists.txt#L95-L101 This results in runtime error: ``` + ./cmake-out/examples/models/llama/llama_main --model_path=model.pte --tokenizer_path=tokenizer.bin '--prompt=Once upon a time,' I tokenizers:regex.cpp:27] Registering override fallback regex E 00:00:00.000453 executorch:operator_registry.cpp:89] Re-registering aten::_cdist_forward.out, from NOT_SUPPORTED I 00:00:00.000494 executorch:operator_registry.cpp:90] key: (null), is_fallback: true F 00:00:00.000497 executorch:operator_registry.cpp:114] In function register_kernels(), assert failed (false): Kernel registration failed with error 18, see error log for details. ``` Like in this job: https://github.com/pytorch/executorch/actions/runs/16207706949/job/45761626062 In order to fix this, we change the logic of linking `${EXECUTORCH_LIBRARIES}` which includes both core and kernel ops lib into only linking `executorch_core`, because the kernel ops lib will be linked outside anyways.
Yep agreed. We should do that after we have CMake top level targets ready. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Customers need the flags this sets (
--whole-archiveor-force_load), otherwise the built operator libraries won't actually register operators.Testing:
I'm not sure that we have automated coverage for this file, so I'm sending a first version adding an intentional break.We have automated coverage for this file.