Require setting all inputs before execution. #13207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shoumikhin
requested review from
JacobSzwejbka,
lucylq and
swolchok
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13207
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 194 PendingAs of commit 65f73e0 with merge base 077feaf ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D79849134 |
shoumikhin
added
ciflow/trunk
release notes: none
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 7, 2025
Summary: Method never cared to check all the inputs were properly set before execution and basically used some default allocated memory for unset inputs. Here we introduce a safety check to guarantee users don't forget to set all inputs explicitly. Reviewed By: JacobSzwejbka Differential Revision: D79849134
shoumikhin
force-pushed
the
export-D79849134
branch
from
87d6c94 to
83e430f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D79849134 |
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 8, 2025
Summary: Method never cared to check all the inputs were properly set before execution and basically used some default allocated memory for unset inputs. Here we introduce a safety check to guarantee users don't forget to set all inputs explicitly. Reviewed By: JacobSzwejbka Differential Revision: D79849134
shoumikhin
force-pushed
the
export-D79849134
branch
from
83e430f to
44055a8
Compare
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 8, 2025
Summary: Method never cared to check all the inputs were properly set before execution and basically used some default allocated memory for unset inputs. Here we introduce a safety check to guarantee users don't forget to set all inputs explicitly. Reviewed By: JacobSzwejbka Differential Revision: D79849134
shoumikhin
force-pushed
the
export-D79849134
branch
from
44055a8 to
19369df
Compare
|
This pull request was exported from Phabricator. Differential Revision: D79849134 |
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 8, 2025
Summary: Pull Request resolved: pytorch#13207 Method never cared to check all the inputs were properly set before execution and basically used some default allocated memory for unset inputs. Here we introduce a safety check to guarantee users don't forget to set all inputs explicitly. Reviewed By: JacobSzwejbka Differential Revision: D79849134
shoumikhin
force-pushed
the
export-D79849134
branch
from
19369df to
77222c1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D79849134 |
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 8, 2025
Summary: Pull Request resolved: pytorch#13207 Method never cared to check all the inputs were properly set before execution and basically used some default allocated memory for unset inputs. Here we introduce a safety check to guarantee users don't forget to set all inputs explicitly. Reviewed By: JacobSzwejbka Differential Revision: D79849134
shoumikhin
force-pushed
the
export-D79849134
branch
2 times, most recently
from
8eba69d to
718c2a9
Compare
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 8, 2025
Summary: Method never cared to check all the inputs were properly set before execution and basically used some default allocated memory for unset inputs. Here we introduce a safety check to guarantee users don't forget to set all inputs explicitly. Reviewed By: JacobSzwejbka Differential Revision: D79849134
|
This pull request was exported from Phabricator. Differential Revision: D79849134 |
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 8, 2025
Summary: Method never cared to check all the inputs were properly set before execution and basically used some default allocated memory for unset inputs. Here we introduce a safety check to guarantee users don't forget to set all inputs explicitly. Reviewed By: JacobSzwejbka Differential Revision: D79849134
shoumikhin
force-pushed
the
export-D79849134
branch
from
718c2a9 to
120f5c0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D79849134 |
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 8, 2025
Summary: Method never cared to check all the inputs were properly set before execution and basically used some default allocated memory for unset inputs. Here we introduce a safety check to guarantee users don't forget to set all inputs explicitly. Reviewed By: JacobSzwejbka Differential Revision: D79849134
shoumikhin
force-pushed
the
export-D79849134
branch
from
120f5c0 to
d21c616
Compare
|
This pull request was exported from Phabricator. Differential Revision: D79849134 |
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 8, 2025
Summary: Pull Request resolved: pytorch#13207 Method never cared to check all the inputs were properly set before execution and basically used some default allocated memory for unset inputs. Here we introduce a safety check to guarantee users don't forget to set all inputs explicitly. Reviewed By: JacobSzwejbka Differential Revision: D79849134
shoumikhin
force-pushed
the
export-D79849134
branch
from
313eecf to
b6a1a52
Compare
JacobSzwejbka
approved these changes
Aug 8, 2025
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 8, 2025
Summary: Method never cared to check all the inputs were properly set before execution and basically used some default allocated memory for unset inputs. Here we introduce a safety check to guarantee users don't forget to set all inputs explicitly. Reviewed By: JacobSzwejbka Differential Revision: D79849134
shoumikhin
force-pushed
the
export-D79849134
branch
from
b6a1a52 to
5f9bf2c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D79849134 |
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 8, 2025
Summary: Method never cared to check all the inputs were properly set before execution and basically used some default allocated memory for unset inputs. Here we introduce a safety check to guarantee users don't forget to set all inputs explicitly. Reviewed By: JacobSzwejbka Differential Revision: D79849134
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 8, 2025
Summary: Method never cared to check all the inputs were properly set before execution and basically used some default allocated memory for unset inputs. Here we introduce a safety check to guarantee users don't forget to set all inputs explicitly. Reviewed By: JacobSzwejbka Differential Revision: D79849134
shoumikhin
force-pushed
the
export-D79849134
branch
from
5f9bf2c to
b356b16
Compare
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 8, 2025
Summary: Method never cared to check all the inputs were properly set before execution and basically used some default allocated memory for unset inputs. Here we introduce a safety check to guarantee users don't forget to set all inputs explicitly. Reviewed By: JacobSzwejbka Differential Revision: D79849134
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 8, 2025
Summary: Method never cared to check all the inputs were properly set before execution and basically used some default allocated memory for unset inputs. Here we introduce a safety check to guarantee users don't forget to set all inputs explicitly. Reviewed By: JacobSzwejbka Differential Revision: D79849134
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 8, 2025
Summary: Method never cared to check all the inputs were properly set before execution and basically used some default allocated memory for unset inputs. Here we introduce a safety check to guarantee users don't forget to set all inputs explicitly. Reviewed By: JacobSzwejbka Differential Revision: D79849134
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 8, 2025
Summary: Method never cared to check all the inputs were properly set before execution and basically used some default allocated memory for unset inputs. Here we introduce a safety check to guarantee users don't forget to set all inputs explicitly. Reviewed By: JacobSzwejbka Differential Revision: D79849134
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 8, 2025
Summary: Method never cared to check all the inputs were properly set before execution and basically used some default allocated memory for unset inputs. Here we introduce a safety check to guarantee users don't forget to set all inputs explicitly. Reviewed By: JacobSzwejbka Differential Revision: D79849134
|
This pull request was exported from Phabricator. Differential Revision: D79849134 |
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 8, 2025
Summary: Pull Request resolved: pytorch#13207 Method never cared to check all the inputs were properly set before execution and basically used some default allocated memory for unset inputs. Here we introduce a safety check to guarantee users don't forget to set all inputs explicitly. Reviewed By: JacobSzwejbka Differential Revision: D79849134
shoumikhin
force-pushed
the
export-D79849134
branch
from
b356b16 to
0004f78
Compare
Summary: Fix the ET_CHECK_OK_OR_RETURN_ERROR macro so MSVC picks the right overload for 1 vs 2+ arguments. This removes bogus trailing-comma cases and resolves MSVC compile errors (C2440, C2064, C2059, C4834). Reviewed By: JacobSzwejbka Differential Revision: D79865456
Summary: Method never cared to check all the inputs were properly set before execution and basically used some default allocated memory for unset inputs. Here we introduce a safety check to guarantee users don't forget to set all inputs explicitly. Reviewed By: JacobSzwejbka Differential Revision: D79849134
shoumikhin
force-pushed
the
export-D79849134
branch
from
0004f78 to
17be76e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D79849134 |
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 9, 2025
Summary: Method never cared to check all the inputs were properly set before execution and basically used some default allocated memory for unset inputs. Here we introduce a safety check to guarantee users don't forget to set all inputs explicitly. Reviewed By: JacobSzwejbka Differential Revision: D79849134
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 9, 2025
Summary: Method never cared to check all the inputs were properly set before execution and basically used some default allocated memory for unset inputs. Here we introduce a safety check to guarantee users don't forget to set all inputs explicitly. Reviewed By: JacobSzwejbka Differential Revision: D79849134
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 9, 2025
Summary: Method never cared to check all the inputs were properly set before execution and basically used some default allocated memory for unset inputs. Here we introduce a safety check to guarantee users don't forget to set all inputs explicitly. Reviewed By: JacobSzwejbka Differential Revision: D79849134
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 9, 2025
Summary: Method never cared to check all the inputs were properly set before execution and basically used some default allocated memory for unset inputs. Here we introduce a safety check to guarantee users don't forget to set all inputs explicitly. Reviewed By: JacobSzwejbka Differential Revision: D79849134
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 9, 2025
Summary: Method never cared to check all the inputs were properly set before execution and basically used some default allocated memory for unset inputs. Here we introduce a safety check to guarantee users don't forget to set all inputs explicitly. Reviewed By: JacobSzwejbka Differential Revision: D79849134
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Aug 9, 2025
Summary: Method never cared to check all the inputs were properly set before execution and basically used some default allocated memory for unset inputs. Here we introduce a safety check to guarantee users don't forget to set all inputs explicitly. Reviewed By: JacobSzwejbka Differential Revision: D79849134
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Method never cared to check all the inputs were properly set before execution and basically used some default allocated memory for unset inputs. Here we introduce a safety check to guarantee users don't forget to set all inputs explicitly.
Differential Revision: D79849134