Skip to content

Source File Checks and Refills for Dtype Selective Zephyr Builds #13211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

BujSet
Copy link
Contributor

@BujSet BujSet commented Aug 8, 2025

Summary

When Zephyr builds the portable operator library for a data type selective build, variables created during ExecuTorch's build are not transparent to the Zephyr build process. This PR introduces a check and refill it the source file lists for the portable operators are not visible to cmake. This fix will likely be helpful for other third party collaborators to use data type selective for integrating ExecuTorch with an external build system.

Test plan

Testing with manual changes to Zephyr CI tests. This PR checks out an executorch fork that already has this change. After applying the change, the zephyr model tests use data type selective build successfully.

Copy link

pytorch-bot bot commented Aug 8, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13211

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Unrelated Failure

As of commit 75f78ff with merge base 9b0feb0 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 8, 2025
@BujSet BujSet requested a review from lucylq August 8, 2025 02:02
@BujSet
Copy link
Contributor Author

BujSet commented Aug 8, 2025

@pytorchbot label "release notes: none"

@pytorch-bot pytorch-bot bot added the release notes: none Do not include this in the release notes label Aug 8, 2025
@BujSet BujSet self-assigned this Aug 8, 2025
@BujSet BujSet added ciflow/binaries/all Release PRs with this label will build wheels for all python versions module: microcontrollers For embedded MCUs like Cortex-M, or RTOS like Zephyr, does not track NPU backend like Arm Ethos. labels Aug 8, 2025
@BujSet BujSet force-pushed the dtype_selective_build_sources_for_clean_zephyr_builds branch from 7a873e3 to ac57a1b Compare August 8, 2025 04:48
@BujSet BujSet marked this pull request as ready for review August 8, 2025 04:51
@BujSet BujSet force-pushed the dtype_selective_build_sources_for_clean_zephyr_builds branch from ac57a1b to 75f78ff Compare August 8, 2025 16:22
@BujSet
Copy link
Contributor Author

BujSet commented Aug 8, 2025

Determined this should be something handled in the zephyr application code, not in the ExecuTorch repo.

@BujSet BujSet closed this Aug 8, 2025
@BujSet BujSet deleted the dtype_selective_build_sources_for_clean_zephyr_builds branch August 8, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/binaries/all Release PRs with this label will build wheels for all python versions CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: microcontrollers For embedded MCUs like Cortex-M, or RTOS like Zephyr, does not track NPU backend like Arm Ethos. release notes: none Do not include this in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant