[WIP] native nvcuvid backend #798
Draft
+1,261
−66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
scotts
reviewed
Aug 13, 2025
| }; | ||
|
|
||
| std::mutex DecoderCache::mutex_; | ||
| std::vector<CachedDecoder> DecoderCache::cached_; |
There was a problem hiding this comment.
I think it's more clear to make mutex_ and cached_ normal member variables of DecoderCache, and then declare an instance of DecoderCache that is itself static.
scotts
reviewed
Aug 13, 2025
| } | ||
| }; | ||
| static CacheCleanup g_cache_cleanup; | ||
|
|
There was a problem hiding this comment.
Doing the above would, I think, enable you to just make this cleanup logic the destructor for DecoderCache.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.