make timeouts configurable #229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 10, 2025
Open
facebook-github-bot
added
the
CLA Signed
tushar00jain
force-pushed
the
pr229
branch
3 times, most recently
from
7653989 to
ca01921
Compare
d4l3k
reviewed
Jul 12, 2025
Summary: while training, we need to set higher quorum timeouts to make sure all replicas can finish training these parameters are only exposed through the manager but users may not be able to access the manager directly e.g. when using torchtitan so make the timeouts configurable using env vars that take precedence over the parameters passed through manager
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
while training, we need to set higher quorum timeouts to make sure all replicas can finish training
these parameters are only exposed through the manager but users may not be able to access the manager directly e.g. when using torchtitan
so make the timeouts configurable using env vars that take precedence over the parameters passed through manager
Stack created with Sapling. Best reviewed with ReviewStack.