Skip to content

Task T228334710 update tuning guide #3433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 9, 2025
Merged

Task T228334710 update tuning guide #3433

merged 4 commits into from
Jul 9, 2025

Conversation

drisspg
Copy link
Contributor

@drisspg drisspg commented Jul 8, 2025

Stacked PRs:


Task T228334710 update tuning guide

drisspg added a commit that referenced this pull request Jul 8, 2025
stack-info: PR: #3433, branch: drisspg/stack/1
Copy link

pytorch-bot bot commented Jul 8, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3433

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit e24805f with merge base 30d8869 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@drisspg drisspg force-pushed the drisspg/stack/1 branch from 563e5ee to 6ffbbb9 Compare July 8, 2025 16:42
@drisspg drisspg requested a review from svekars July 8, 2025 16:42
@drisspg drisspg added the tutorials_audit used on tutorial audit PRs label Jul 8, 2025
drisspg added a commit that referenced this pull request Jul 8, 2025
stack-info: PR: #3433, branch: drisspg/stack/1
@drisspg drisspg force-pushed the drisspg/stack/1 branch from 6ffbbb9 to 7a661f0 Compare July 8, 2025 16:46
drisspg added a commit that referenced this pull request Jul 8, 2025
stack-info: PR: #3433, branch: drisspg/stack/1
@drisspg drisspg force-pushed the drisspg/stack/1 branch from 7a661f0 to 2ee52cd Compare July 8, 2025 16:46
Copy link
Member

@msaroufim msaroufim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The prereq section is not adding much and there are some CPU only optimizations in this guide

@drisspg
Copy link
Contributor Author

drisspg commented Jul 8, 2025

@msaroufim it was part of the task so I added, whats wrong w/ having cpu optimizations?

drisspg added a commit that referenced this pull request Jul 8, 2025
stack-info: PR: #3433, branch: drisspg/stack/1
@drisspg drisspg force-pushed the drisspg/stack/1 branch from 2ee52cd to e2f04f0 Compare July 8, 2025 16:53
@msaroufim
Copy link
Member

Might have been too brief sorry, the prereq section said something like: "CUDA enabled device recommended" but then the post had details on CPU only optimizations that were quite comprehensive and solid

@drisspg
Copy link
Contributor Author

drisspg commented Jul 8, 2025

Got it, remove the section, agreed it doesn't add much besides "you need pytorch to run pytorch"

stack-info: PR: #3433, branch: drisspg/stack/1
@drisspg drisspg force-pushed the drisspg/stack/1 branch from e2f04f0 to 3450dfd Compare July 8, 2025 18:09
@sekyondaMeta sekyondaMeta merged commit 9e73898 into main Jul 9, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed tutorials_audit used on tutorial audit PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants