Skip to content

[CI][lint] Add lintrunner + spaces, tabs, newlines linters #3467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 16, 2025

Conversation

clee2000
Copy link
Contributor

@clee2000 clee2000 commented Jul 16, 2025

  • Add lint job for lintrunner
  • Add lintrunner.toml
  • Add newlines, spaces, tabs lines
    • These download the linter from pytorch/pytorch. The sha is main branch as of now. Not sure if I should do this or just copy the linters over
    • Big exclusion lists because I don't want to make a ton of changes in 1 PR at once

new lines checks that files end with just 1 \n
spaces checks that there are no trailing whitespace on lines
tabs checks that spaces are used instead of tabs

Copy link

pytorch-bot bot commented Jul 16, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3467

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 1 Pending

As of commit 1898dac with merge base 755434d (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@clee2000 clee2000 requested a review from svekars July 16, 2025 17:17
Copy link
Contributor

@svekars svekars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@clee2000 clee2000 merged commit 70c85a7 into main Jul 16, 2025
24 checks passed
svekars pushed a commit that referenced this pull request Jul 17, 2025
* Add lint job for lintrunner
* Add lintrunner.toml
* Add newlines, spaces, tabs lines
  * These download the linter from pytorch/pytorch.  The sha is main branch as of now.  Not sure if I should do this or just copy the linters over
  * Big exclusion lists because I don't want to make a ton of changes in 1 PR at once



new lines checks that files end with just 1 `\n`
spaces checks that there are no trailing whitespace on lines
tabs checks that spaces are used instead of tabs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants