Implement collective gather op #9435
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfolie
commented
Jul 1, 2025
test/pjrt/test_collective_ops_tpu.py
Outdated
Comment on lines
106
to
128
| @staticmethod | ||
| def _scatter(): | ||
| dist.init_process_group("xla", init_method='xla://') | ||
| device = torch_xla.device() | ||
| world_size = xr.world_size() | ||
| tensors = None | ||
| if xr.global_ordinal() == 0: | ||
| tensors = [ | ||
| torch.tensor([i], device=device, dtype=torch.float) | ||
| for i in range(world_size) | ||
| ] | ||
|
|
||
| output_tensor = torch.tensor([-1], dtype=torch.float, device=device) | ||
| dist.scatter(output_tensor, tensors, src=0) | ||
| return output_tensor.cpu() | ||
|
|
||
| def test_scatter(self): | ||
| """self._scatter instantiates a list of tensors [[0], [1], ..., [n-1]] | ||
| on device 0, then scatters it. Device i should therefore receive [i].""" | ||
| results = pjrt.run_multiprocess(self._scatter) | ||
| for ordinal, value in results.items(): | ||
| np.testing.assert_array_equal(value, [ordinal]) | ||
|
|
There was a problem hiding this comment.
Just moving this test into the appropriate class
bfolie
commented
Jul 1, 2025
test/pjrt/test_collective_ops_tpu.py
Outdated
Comment on lines
339
to
360
| @staticmethod | ||
| def _scatter(): | ||
| dist.init_process_group("xla", init_method='xla://') | ||
| device = torch_xla.device() | ||
| world_size = xr.world_size() | ||
| tensors = None | ||
| if xr.global_ordinal() == 0: | ||
| tensors = [ | ||
| torch.tensor([i], device=device, dtype=torch.float) | ||
| for i in range(world_size) | ||
| ] | ||
|
|
||
| output_tensor = torch.tensor([-1], dtype=torch.float, device=device) | ||
| dist.scatter(output_tensor, tensors, src=0) | ||
| return output_tensor.cpu() | ||
|
|
||
| def test_scatter(self): | ||
| """self._scatter instantiates a list of tensors [[0], [1], ..., [n-1]] | ||
| on device 0, then scatters it. Device i should therefore receive [i].""" | ||
| results = pjrt.run_multiprocess(self._scatter) | ||
| for ordinal, value in results.items(): | ||
| np.testing.assert_array_equal(value, [ordinal]) |
|
Failing tests are expected until the TPU CI cluster is updated to use python 3.12. See #9434 |
pgmoka
reviewed
Jul 8, 2025
…/xla into bfolie/gather-collective
pgmoka
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#9315