Fix spmd sharding visualization when device index is >= 10 #9475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffhataws
commented
Jul 11, 2025
jeffhataws
force-pushed
the
jeffhataws_dtensor2
branch
from
fa3a464 to
7b2c4b7
Compare
|
@bfolie do you know why torchprime tests are failing? |
|
torchprime testing is being fixed #9481 |
bfolie
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously you would get an error trying to visualize the sharding spec when device index >= 10. This fixes the problem, and also add a print of the spec itself for additional level of debug.