Rename XLA_SHOW_CPP_ERROR_CONTEXT to TORCH_SHOW_CPP_STACKTRACES
#9482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename `XLA_SHOW_CPP_ERROR_CONTEXT` to `TORCH_SHOW_CPP_STACKTRACES`.
ysiraichi
requested review from
zhanyong-wan and
ghpvnist
and removed request for
zhanyong-wan
ghpvnist
approved these changes
Jul 15, 2025
| @@ -40,7 +40,7 @@ inline constexpr char kEnvDistSvcShutdownTimeoutInMin[] = | |||
|
|
|||
| // When set to true, this enables showing C++ error context in backtraces, | |||
| // which can be helpful for debugging but may clutter logs when not needed | |||
| inline constexpr char kEnvShowCppErrorContext[] = "XLA_SHOW_CPP_ERROR_CONTEXT"; | |||
| inline constexpr char kEnvShowCppStacktraces[] = "TORCH_SHOW_CPP_STACKTRACES"; | |||
There was a problem hiding this comment.
Let's also link to the torch documentation page to remind users it's the same env variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames the environment variable
XLA_SHOW_CPP_ERROR_CONTEXTtoTORCH_SHOW_CPP_STACKTRACESfor consistency with existing PyTorch development practices.Key Changes
kEnvShowCppErrorContextvariable (in env_vars.h) was also renamed tokEnvShowCppStacktraces