Add experiment_metadata to analysis #944
Draft
+40
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Base experiment supports an overridable method to provide experiment metadata, which is often useful to communicate with analysis classes. This PR adds
experiment_data
method toBaseAnalysis
so that every subclass can easily access to this metadata.Details and comments
Follow up; In principle, analysis class doesn't need to take full
ExperimentData
object because this object also has unnecessary mechanism for remote database access and job control. Thus, it's sufficient for analysis to takeExperimentData.data()
andExperimentData.metadata
. New mechanism allowsBaseAnalysis._run_analysis
to run analysis with experiment metadata, without taking full experiment data object.Two experiments and analysis have been updated to showcase how new property can be used.