Skip to content

Refactoring to include husky pre-commit hooks, improved eslint rules and manual chunking + more #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 1, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ node_modules
dist
dist-ssr
*.local
*.tsbuildinfo

# Editor directories and files
.vscode/*
Expand Down
2 changes: 2 additions & 0 deletions .husky/pre-commit
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
npm run lint
npm run build
64 changes: 62 additions & 2 deletions eslint.config.js
Original file line number Diff line number Diff line change
@@ -1,17 +1,36 @@
import { fixupPluginRules } from "@eslint/compat";
import { FlatCompat } from "@eslint/eslintrc";
import js from "@eslint/js";
import globals from "globals";
import reactPlugin from 'eslint-plugin-react';
import reactHooks from "eslint-plugin-react-hooks";
import reactRefresh from "eslint-plugin-react-refresh";
import tseslint from "typescript-eslint";
import prettier from "eslint-plugin-prettier/recommended";

const project = "./tsconfig.app.json";
// eslint flat structure backwards compatibility
const compat = new FlatCompat({
recommendedConfig: js.configs.recommended,
});

function legacyPlugin(name, alias = name) {
const plugin = compat.plugins(name)[0]?.plugins?.[alias];
if (!plugin) {
throw new Error(`Unable to resolve plugin ${name} and/or alias ${alias}`);
}
return fixupPluginRules(plugin);
}

export default tseslint.config(
{ ignores: ["dist"] },
{ ignores: ["node_modules", "dist", "build"] },
{
extends: [
js.configs.recommended,
...tseslint.configs.recommended,
prettier,
...compat.extends("plugin:import/typescript"),
reactPlugin.configs.flat.recommended,
],
files: ["**/*.{ts,tsx}"],
languageOptions: {
Expand All @@ -21,14 +40,55 @@ export default tseslint.config(
plugins: {
"react-hooks": reactHooks,
"react-refresh": reactRefresh,
import: legacyPlugin("eslint-plugin-import", "import"),
},
settings: {
"import/resolver": {
typescript: {
project,
alwaysTryTypes: true,
},
},
},
rules: {
...reactHooks.configs.recommended.rules,
"@typescript-eslint/no-empty-object-type": "off",
"@typescript-eslint/no-unused-vars": ["error", {
"argsIgnorePattern": "^_",
"varsIgnorePattern": "^_",
"caughtErrorsIgnorePattern": "^_"
}],
"import/order": ["error", {
"groups": [
"builtin",
"external",
"internal",
["parent", "sibling"],
"index",
"object",
"type",
"unknown"
],
"pathGroups": [
{
"pattern": "@*",
"group": "internal",
"position": "after"
}
],
"pathGroupsExcludedImportTypes": ["builtin", "internal"],
"newlines-between": "always",
"alphabetize": {
"order": "asc",
"caseInsensitive": true
}
}],
"react/react-in-jsx-scope": "off",
"react-refresh/only-export-components": [
"warn",
{ allowConstantExport: true },
],
"prettier/prettier": "error",
"semi": ["error", "always"],
},
}
);
Loading