-
Notifications
You must be signed in to change notification settings - Fork 937
Add example for picotool reset #683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JohnAZoidberg
wants to merge
1
commit into
raspberrypi:master
Choose a base branch
from
FrameworkComputer:reset-example
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
if (TARGET tinyusb_device) | ||
add_executable(picotool_reset | ||
picotool_reset.c | ||
) | ||
|
||
target_compile_definitions(picotool_reset PRIVATE | ||
PICO_STDIO_USB_ENABLE_RESET_VIA_VENDOR_INTERFACE=1 | ||
PICO_STDIO_USB_RESET_INTERFACE_SUPPORT_MS_OS_20_DESCRIPTOR=1 | ||
) | ||
|
||
# pull in common dependencies | ||
target_link_libraries(picotool_reset pico_stdlib) | ||
|
||
# enable usb interface, disable uart output | ||
pico_enable_stdio_usb(picotool_reset 1) | ||
pico_enable_stdio_uart(picotool_reset 0) | ||
|
||
# create map/bin/hex/uf2 file etc. | ||
pico_add_extra_outputs(picotool_reset) | ||
|
||
# add url via pico_set_program_url | ||
example_auto_set_url(picotool_reset) | ||
elseif(PICO_ON_DEVICE) | ||
message("Skipping picotool_reset because TinyUSB submodule is not initialized in the SDK") | ||
endif() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
/** | ||
* Copyright (c) 2020 Raspberry Pi (Trading) Ltd. | ||
* Copyright (c) 2025 Framework Computer Inc | ||
* | ||
* SPDX-License-Identifier: BSD-3-Clause | ||
*/ | ||
|
||
#include "pico/stdlib.h" | ||
|
||
int main() { | ||
stdio_init_all(); | ||
|
||
// Don't exit, wait for control transfer | ||
while (true) {} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These defines are already set to 1 by default, so I'm not sure how this example differs from any of the other examples which use
pico_enable_stdio_usb
(eghello_usb
,hello_anything
,hello_universal
)? All of those examples already have support for picotool reset by defaultThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's useful to know how to add support for the reset interface if you have your own usb cdc setup? usb/device/dev_multi_cdc tries to do that but I seem to recall it doesn't quite work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just had a quick hack and got it working with dev_multi_cdc, but it'll need a few SDK changes too to allow using the reset interface without the stdio_usb default descriptors - will try more in a week or so
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I didn't realize that. I tried a long time with the usb examples and also those from tinyusb but the defines never worked on those. So once I finally tried them on the hello example it did work.
Then instead of my code changes, it might be useful to keep the readme changes and explicitly document that the hello example does indeed support the reset protocol.
Cool, thanks!