docs(basic) add bs5 basic examples #239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just realize I should keep the bootstrap v4 example instead of replacing it with the v5 basic example since bootstrap v4 is still supported, so I've restored the original basic example and move it to basic-v5 in the last commit. |
lcheunglci
changed the title
kyletsang
approved these changes
Oct 22, 2021
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did the version bump from bootstrap 4.6.0 to 5.1.3, and also bumped the version of react-bootstrap from 1.5.2 to 2.0.0 and replaced the deprecated
<Jumbotron>example with a<Container>with similar behaviour.