Skip to content

document custom back button behavior #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 1, 2018
Merged

document custom back button behavior #11

merged 2 commits into from
Feb 1, 2018

Conversation

vonovak
Copy link
Member

@vonovak vonovak commented Jan 25, 2018

hi! documenting the android back button behavior.

In my app, I once also tried to do custom handling of back button while a drawer is open. Unfortunately, my event listeners were not called (react-navigation was swallowing the events) and I had to work around that in a different way, which is why this is not documented.

Let me know if this looks good :)

@vonovak vonovak changed the title document custom back button document custom back button behavior Jan 25, 2018
@react-navigation-bot
Copy link

react-navigation-bot commented Jan 25, 2018

Deploy preview for react-navigation ready!

Built with commit 025a88d

https://deploy-preview-11--react-navigation.netlify.com

@brentvatne
Copy link
Member

In my app, I once also tried to do custom handling of back button while a drawer is open. Unfortunately, my event listeners were not called (react-navigation was swallowing the events) and I had to work around that in a different way, which is why this is not documented.

this is exactly why i want to document this! we should be very upfront about the issues faced by our current implementations. by putting them in the open, people at least know that the approach they are using isn't great and maybe come up with ideas for how to improve, but also it gives us more motivation and shared knowledge that we need to improve.

does the doc cover this bug / odd behavior?

@vonovak
Copy link
Member Author

vonovak commented Jan 26, 2018

@brentvatne fair point. The docs currently does not cover this, afaik. I will add it to this page.

@brentvatne brentvatne merged commit 86bc5f2 into react-navigation:master Feb 1, 2018
kant added a commit to kant/react-navigation.github.io that referenced this pull request Mar 27, 2018
On react-navigation#141: navigationOptions or `navigationOptions`?
vonovak added a commit that referenced this pull request Mar 27, 2018
brentvatne pushed a commit that referenced this pull request Mar 27, 2018
On #141: navigationOptions or `navigationOptions`?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants