Translate React tutorial #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bentlusty
suggested changes
Feb 20, 2019
There was a problem hiding this comment.
Hey @galtalmor , added some comments on your translation. if you can fix those we can merge the PR
content/tutorial/nav.yml
Outdated
| @@ -1,111 +1,111 @@ | |||
| - title: Tutorial | |||
| items: | |||
| - id: before-we-start-the-tutorial | |||
| title: Before We Start the Tutorial | |||
| title: לפני שאנחנו מתחילים במדיך | |||
There was a problem hiding this comment.
A little typo here. במדיך -> במדריך
content/tutorial/nav.yml
Outdated
| href: /tutorial/tutorial.html#completing-the-game | ||
| forceInternal: true | ||
| subitems: | ||
| - id: lifting-state-up | ||
| title: Lifting State Up | ||
| title: הרמת המצב למעלה |
There was a problem hiding this comment.
I think we should use the word "State" here as you used "Props" and "React" above.
content/tutorial/nav.yml
Outdated
| href: /tutorial/tutorial.html#storing-a-history-of-moves | ||
| forceInternal: true | ||
| - id: lifting-state-up-again | ||
| title: Lifting State Up, Again | ||
| title: הרמת המצב למעלה, שוב |
There was a problem hiding this comment.
See the comment - "I think we should use the word "State" here as you used "Props" and "React" above." above
content/tutorial/tutorial.md
Outdated
|
|
||
| ## Before We Start the Tutorial {#before-we-start-the-tutorial} | ||
| ## לפני שאנחנו מתחילים במדיך {#before-we-start-the-tutorial} |
There was a problem hiding this comment.
Little type here: במדיך -> במדריך
content/tutorial/tutorial.md
Outdated
|
|
||
| You can close the tic-tac-toe game once you're familiar with it. We'll be starting from a simpler template in this tutorial. Our next step is to set you up so that you can start building the game. | ||
| תוכלו לסגור את משחק האיסק-עיגול ברגע שאתם מבינים אותו. אנו מתחילים מתבנית פשוטה יותר במדריך זה. השלב הבא שלנו הוא לארגן אתכם כך שתוכלו להתחיל לבנות את המשחק. |
There was a problem hiding this comment.
Little type here: האיסק -> האיקס
content/tutorial/tutorial.md
Outdated
|
|
||
| Now that you're set up, let's get an overview of React! | ||
| כעת שאתם מוכנין, בואו נקבל סקירה כללית של React! |
There was a problem hiding this comment.
Little typo: מוכנין -> מוכנים
|
Thanks @bentlusty . Fixed. |
|
@bentlusty Can we merge? |
galtalmor
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes both: