Skip to content

Translate Code Editor Component #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 27, 2019
Merged

Translate Code Editor Component #27

merged 2 commits into from
Feb 27, 2019

Conversation

itayyehezkel
Copy link
Collaborator

No description provided.

@tesseralis tesseralis mentioned this pull request Feb 27, 2019
Closed
88 tasks
galnir
galnir previously requested changes Feb 27, 2019
View reviewed changes
Copy link
Collaborator

@galnir galnir left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to ask you to change להגרם to להיגרם but the word can be written in both ways, and we need to decide in what way we write it in our future TRANSLATION.md

@galnir galnir dismissed their stale review February 27, 2019 15:17

Doesn't need to be changed for now

@itayyehezkel
Copy link
Collaborator Author

Yes you right, but I changed it anyway because it feels correct.

@itayyehezkel itayyehezkel merged commit 3be560a into reactjs:master Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galnir galnir galnir left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@itayyehezkel @galnir