Skip to content

Translate Glossary page #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 1, 2019
Merged

Conversation

galtalmor
Copy link
Collaborator

No description provided.

@galtalmor galtalmor requested review from galnir and itayyehezkel April 1, 2019 13:26
@netlify
Copy link

netlify bot commented Apr 1, 2019

Deploy preview for he-reactjs ready!

Built with commit 8b9496d

https://deploy-preview-49--he-reactjs.netlify.com


## [Lifecycle Methods](/docs/state-and-lifecycle.html#adding-lifecycle-methods-to-a-class) {#lifecycle-methods}
## [מתודות מעגל חיים](/docs/state-and-lifecycle.html#adding-lifecycle-methods-to-a-class) {#lifecycle-methods}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though lifecycle is מעגל חיים, do you think it would also be correct to name it מתודות מחזוריות or מתודות בעלות מחזור חיים? Just a suggestion

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It relates to the methods of the lifecycle, it does not relate to methods that have lifecycle so "מתודות בעלות מחזור חיים" is not a good fit, and neither מתודות מחזוריות doesn't work I think since this option tends more towards the wrong option.
The methods are related to the lifecycle and not the other way around, so I think leaving it as is would be best.


Keys only need to be unique among sibling elements in the same array. They don't need to be unique across the whole application or even a single component.
מפתחות צריכים להיות ייחודיים רק בין אלמנטים אחים באותו מערך. הם לא צריכים להיות ייחודיים על פני האפליקציה כולה או אפילו קומפוננטה אחת.

Don't pass something like `Math.random()` to keys. It is important that keys have a "stable identity" across re-renders so that React can determine when items are added, removed, or re-ordered. Ideally, keys should correspond to unique and stable identifiers coming from your data, such as `post.id`.
Copy link
Collaborator

@galnir galnir Apr 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot to delete this paragraph after you translated it

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks!

Copy link
Collaborator

@galnir galnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through it twice, superb translation 👍
Just remove the English paragraph you didn't remove and check out my suggestion aswell

@galtalmor
Copy link
Collaborator Author

galtalmor commented Apr 1, 2019

@galnir Thanks! :)

@galtalmor galtalmor merged commit 42d48dc into reactjs:master Apr 1, 2019
@tesseralis tesseralis mentioned this pull request Apr 1, 2019
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants