reset cmdable.process when copying cluster client #774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmihailenco
added a commit
that referenced
this pull request
Mar 11, 2020
reset cmdable.process when copying cluster client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #773
The problem is
c.cmdable.setProcess(c.Process)in the factory method. The reference toc.Processis specific to that instance. When we copy viacp := *c, the new client retains that reference, and thus methods invoked on the new client will end up callingProcesson the old client.To fix this, I took the same approach used in the non-cluster client: https://github.com/go-redis/redis/blob/master/redis.go#L361