Skip to content

[v25.1.x] r/consensus: stop consumable offset monitor #26275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 29, 2025
Merged

[v25.1.x] r/consensus: stop consumable offset monitor #26275

merged 1 commit into from
May 29, 2025

Conversation

vbotbuildovich
Copy link
Collaborator

Backport of PR #26260

@mmaslankaprv @vbotbuildovich
r/consensus: stop consumable offset monitor
1c06b66 
Previously consumable offset monitor wasn't stopped, that might lead to
situation in which monitor caller waited indefinitely for it to stop.

Signed-off-by: Michał Maślanka <[email protected]>
(cherry picked from commit 00b051b)
@vbotbuildovich vbotbuildovich added this to the v25.1.x-next milestone May 28, 2025
@vbotbuildovich vbotbuildovich added the kind/backport PRs targeting a stable branch label May 28, 2025
@vbotbuildovich
Copy link
Collaborator Author

CI test results

test results on build#66528
test_class test_method test_arguments test_kind job_url test_status passed reason
ConsumerGroupBalancingTest test_coordinator_nodes_balance ducktape https://buildkite.com/redpanda/redpanda/builds/66528#01971964-5272-43ca-a7fb-949aa035d753 FLAKY 20/21 upstream reliability is '97.82608695652173'. current run reliability is '95.23809523809523'. drift is 2.58799 and the allowed drift is set to 50. The test should PASS
RandomNodeOperationsTest test_node_operations {"cloud_storage_type": 2, "enable_failures": true, "mixed_versions": true, "with_chunked_compaction": true, "with_iceberg": false, "with_tiered_storage": true} ducktape https://buildkite.com/redpanda/redpanda/builds/66528#01971957-32c4-4cd8-a1ab-7989778aeabd FLAKY 18/21 upstream reliability is '100.0'. current run reliability is '85.71428571428571'. drift is 14.28571 and the allowed drift is set to 50. The test should PASS

@mmaslankaprv mmaslankaprv merged commit f4eb1da into redpanda-data:v25.1.x May 29, 2025
17 checks passed
@piyushredpanda piyushredpanda modified the milestones: v25.1.x-next, v25.1.5 Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmaslankaprv mmaslankaprv mmaslankaprv approved these changes

Assignees
No one assigned
Labels
area/redpanda kind/backport PRs targeting a stable branch
Projects
None yet
Milestone
v25.1.5
Development

Successfully merging this pull request may close these issues.
3 participants
@vbotbuildovich @mmaslankaprv @piyushredpanda