-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Update API docs for v5 #480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
let result = {} | ||
const actions = bindActionCreators(actionCreators, dispatch) | ||
const addTodo = (text) => actions.addTodo(ownProps.userId, text) | ||
const memoize = initShallowMemoizer() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, not sure to have seen this memoizer used in this example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops. That's dead code I think.
OK, let's merge this in for now. |
* updates docs for changes in v5 (WORK IN PROGRESS) * update docs for changes in v5 * removes unused code from example * adds a tags to api.md for direct linking
* updates docs for changes in v5 (WORK IN PROGRESS) * update docs for changes in v5 * removes unused code from example * adds a tags to api.md for direct linking
Hi. I was reading https://github.com/reactjs/react-redux/blob/master/docs/api.md#examples-1 and this PR contains the latest commit changing that part. I guess you have a plan to update the example for
|
* updates docs for changes in v5 (WORK IN PROGRESS) * update docs for changes in v5 * removes unused code from example * adds a tags to api.md for direct linking
This can certainly be better, but it's not a bad start.