`String.length` not inlined in v10

[cristianoc]

This:

let stringLengthNoSideEffects = String.length("sdkdl")

now produces

var stringLengthNoSideEffects = "sdkdl".length;

while it used to be

var stringLengthNoSideEffects = 5;

[cristianoc]

This is because the parser now sends strings as unicode, and the compiler does not have a length function that matches the one of JS (utf16 code units).
Otherwise it could compute it at compile time in string_length inside js_exp_make.ml.

[cristianoc]

The parser might already have such a function and if so one could hook it up to the compiler.

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.