Skip to content

Adding a package-lock.json, and supporting an opam local-switch #2985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ELLIOTTCABLE
Copy link
Contributor

Apologies if the lack of the package-lock.json was intentional for some build-system reason that I don't understand; but in theory at least, this should make builds more reproducible for contributors / CI.

Also, switches work slightly differently on the new opam 2.0; so I updated the documentation correspondingly.

(Just a little pull-req as I get warmed up on contributing; hope it's welcome!)

@bobzhang
Copy link
Member

bobzhang commented Aug 5, 2018

@ELLIOTTCABLE Thanks for having a look! I am a bit confused about package.json lock file, since we dont really depend on any npm packages. our package.json may be a little confusing, all dev dependencies are optional that are not really needed in the CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants